chore: clean-up#13390
Merged
Merged
Conversation
Propagates fix from 9757a36 ("chore: clean-up") to sibling packages whose `enum` tape tests iterate the enum-key array `o` and look up `obj[ o[i] ]` — stdlib requires spaces inside every `[ ... ]` accessor, including the inner `[ i ]`. Applies verbatim across eleven sibling packages under `blas/base/*`, `ndarray/*`, `ml/base/*`, and `stats/base/ztest/alternatives`.
Propagates fix from 49456e6 ("bench: use `isnanf` in `strided/napi/smap`") to sibling benchmark files that operate on Float32Array or Complex64Array data. Renames the local require from `@stdlib/math/base/assert/is-nan` to `@stdlib/math/base/assert/is-nanf` and updates the corresponding call sites so single-precision NaN checks are used throughout the affected benchmarks.
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
approved these changes
Jul 9, 2026
kgryte
changed the title
isnanf fixes across sibling packages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Propagating fixes merged to
developbetween 2026-07-08 13:12 UTC and 2026-07-09 13:12 UTC to sibling packages that exhibit the same defect.chore: bracket spacingPropagates the fix from
9757a36a(chore: clean-up), applyingobj[ o[i] ]→obj[ o[ i ] ]in enum-key tape test loops to restore stdlib's inner-spacing convention on every[ ... ]accessor. Same one-line pattern, mechanically applied across the remaining packages that missed the original clean-up.@stdlib/blas/base/diagonal-types@stdlib/blas/base/layouts@stdlib/blas/base/matrix-orientations@stdlib/blas/base/matrix-triangles@stdlib/blas/base/operation-sides@stdlib/blas/base/transpose-operations@stdlib/ml/base/kmeans/algorithms@stdlib/ml/base/sgd-classification/learning-rates@stdlib/ndarray/casting-modes@stdlib/ndarray/orders@stdlib/stats/base/ztest/alternativesbench: isnanf on single-precision benchmarksPropagates the fix from
49456e6b("bench: useisnanfinstrided/napi/smap"): benchmarks operating onFloat32Array/Complex64Arraydata must check for NaN withis-nanf(single-precision), notis-nan(double-precision). Each file gets the require path, local variable name, and every call site renamed fromisnan/is-nantoisnanf/is-nanf; 18 benchmark files across 7 packages.@stdlib/blas/base/ccopy— 4 benchmark files@stdlib/blas/base/cswap— 4 benchmark files@stdlib/strided/base/cmap— 2 benchmark files@stdlib/strided/base/mskunary— 2 accessor benchmark files@stdlib/strided/base/nullary— 2 accessor benchmark files@stdlib/strided/base/smap— 2 benchmark files@stdlib/strided/base/unary— 2 accessor benchmark filesRelated Issues
None.
Questions
None.
Other
Validation
Candidate sites were located by pattern search scoped to
lib/node_modules/@stdlib/(bracket spacing: literal grep forobj[ o[i] ]; isnanf: benchmarks requiringis-nanwhile operating onFloat32ArrayorComplex64Array). Every surviving site was independently verified by two validators reading each file in full; the isnanf candidate list dropped from 32 → 18 after that pass.Sites deliberately excluded from the isnanf propagation:
blas/ext/base/cindex-of-columnandblas/ext/base/clast-index-of-row—isnanargument is the integer index return value, not an f32 element access. Rejected by both validators.blas/gdot/benchmark.float32.js,blas/gswap/benchmark.float32.js, andstats/base/sdsnanmean(four files) — argument is a scalar return from a routine whose accumulator is double-precision. Both validators marked these asneeds-human/rejected; propagation would not match the source pattern verbatim.The source commits
f449b5c1(docs: update related packages sections) and262f2dc2(docs: update namespace table of contents) are bot-generated and were skipped: they are not fix patterns.7eb19700(fix: rename enum) was skipped because the sole sibling (ml/base/sgd-classification/learning-rates) already conforms to the new enum-naming convention.2fc0cf41(docs: fix example inutils/push) is confined to a single private helper's docstring; no sibling packages exhibit the defect.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by an automated propagation routine driven by Claude Code (Anthropic). Source commits were categorised, propagation targets were located by ripgrep, and each target was independently verified by two model validators reading each file in full before any patch was applied. All propagations are mechanical (verbatim substitutions matching the source commit's fix). No new tests or benchmarks were authored; only the specified rename/spacing changes were applied.
@stdlib-js/reviewers
Generated by Claude Code